Re: [PATCH] PCI: vmd: Free up IRQs on suspend path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 07, 2019 at 03:10:09PM +0000, Derrick, Jonathan wrote:
> On Thu, 2019-02-07 at 12:07 +0100, Greg KH wrote:
> > On Wed, Feb 06, 2019 at 02:36:16PM -0700, Sushma Kalakota wrote:
> > > commit e2b1820bd5d09 upstream
> > > 
> > > Free up the IRQs we request on the suspend path and reallocate them
> > > on the
> > > resume path.
> > > 
> > > Fixes this error:
> > > 
> > >   CPU 111 disable failed: CPU has 9 vectors assigned and there are
> > > only 0 available.
> > >   Error taking CPU111 down: -34
> > >   Non-boot CPUs are not disabled
> > >   Enabling non-boot CPUs ...
> > > 
> > > For consistency, this patch also includes the VMD portion of:
> > > 3eefa790c9681: PCI: host: Mark PCIe/PCI (MSI) cascade ISR as
> > > IRQF_NO_THREAD
> > > 
> > > CC: Scott Bauer <scott.bauer@xxxxxxxxx>
> > > CC: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > > CC: Keith Busch <keith.busch@xxxxxxxxx>
> > > Reviewed-by: Jon Derrick <jonathan.derrick@xxxxxxxxx>
> > > Signed-off-by: Sushma Kalakota <sushmax.kalakota@xxxxxxxxx>
> > > ---
> > >  drivers/pci/host/vmd.c | 18 +++++++++++++++++-
> > >  1 file changed, 17 insertions(+), 1 deletion(-)
> > > 
> > 
> > What stable kernel tree(s) do you want this patch applied to?  And
> > why?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Greg,
> 
> This is for 4.9.y and intended to increase reliability of
> suspend/resume not leading to a failure to suspend or failure to
> resume, either of which would be undesireable to users of the feature,
> and potentially make the overall feature unusable if suspend/resume
> were user requirement.

Ok, but who is still using this old kernel on these types of machines?
Why haven't they moved to 4.14 or newer by now?  The normal systems that
use 4.9 or older should not need this, as they are the horrid SoC trees.

Who has reported this problem in their systems?

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux