4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yan, Zheng <zyan@xxxxxxxxxx> commit d95e674c01cfb5461e8b9fdeebf6d878c9b80b2f upstream. snap realm and corresponding inode have pointers to each other. The two pointer should get clear at the same time. Otherwise, snap realm's pointer may reference freed inode. Cc: stable@xxxxxxxxxxxxxxx # 4.17+ Signed-off-by: "Yan, Zheng" <zyan@xxxxxxxxxx> Reviewed-by: Luis Henriques <lhenriques@xxxxxxxx> Signed-off-by: Ilya Dryomov <idryomov@xxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/ceph/caps.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -1032,6 +1032,8 @@ static void drop_inode_snap_realm(struct list_del_init(&ci->i_snap_realm_item); ci->i_snap_realm_counter++; ci->i_snap_realm = NULL; + if (realm->ino == ci->i_vino.ino) + realm->inode = NULL; spin_unlock(&realm->inodes_with_caps_lock); ceph_put_snap_realm(ceph_sb_to_client(ci->vfs_inode.i_sb)->mdsc, realm);
