Re: [PATCH] PCI: dwc: Move interrupt acking into the proper callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 21, 2019 at 03:27:09PM +0100, Niklas Cassel wrote:
> From: Marc Zyngier <marc.zyngier@xxxxxxx>
> 
> The write to the status register is really an ACK for the HW,
> and should be treated as such by the driver. Let's move it to the
> irq_ack() callback, which will prevent people from moving it around
> in order to paper over other bugs.
> 
> Fixes: 8c934095fa2f ("PCI: dwc: Clear MSI interrupt status after it is handled,
> not before")
> Fixes: 7c5925afbc58 ("PCI: dwc: Move MSI IRQs allocation to IRQ domains
> hierarchical API")
> Link: https://lore.kernel.org/linux-pci/20181113225734.8026-1-marc.zyngier@xxxxxxx/
> Reported-by: Trent Piepho <tpiepho@xxxxxxxxxx>
> Tested-by: Niklas Cassel <niklas.cassel@xxxxxxxxxx>
> Tested-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>
> Tested-by: Stanimir Varbanov <svarbanov@xxxxxxxxxx>
> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
> [lorenzo.pieralisi@xxxxxxx: updated commit log]
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> ---
> Original upstream commit SHA1: 3f7bb2ec20ce07c02b2002349d256c91a463fcc5
> 
> Sending a backport (which is authored by Marc, just like the original
> commit), for 4.14-stable, since the original commit failed to apply there.
> 
> Not sure if Tested-by tags should remain.
> Mine can be kept, since I've tested the backport.
> 
>  drivers/pci/dwc/pcie-designware-host.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)

Now queued up, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux