On 1/21/2019 3:10 AM, Sagi Grimberg wrote: >> This looks ok to me: >> >> Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > Applied to nvme-5.0 > >> In the long run I wonder if we should get rid of the ѕtatic >> preallocation entirely and just use a free pool to avoid constant >> reallocations.. > > you mean a kmem_cache? very possible, we can also make the command > struct to contain the rsp behind it to avoid the extra allocation... Hey guys, If every command struct requires a rsp, then it seems simpler to contain it in the command struct. My 2 cents... Steve.