Hi, On Fri, 2013-12-06 at 15:54 +0000, Luis Henriques wrote: > On Thu, Nov 28, 2013 at 10:11:24AM +0000, Steven Whitehouse wrote: > > > > For 3.12 stable. Upstream ref: > > > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/gfs2/inode.c?id=ea0341e071527d5cec350917b01ab901af09d758 > > Hi Steven, this patch seems to be applicable to the 3.11 kernel as > well. I'm queuing it for the next release. > > Cheers, > -- > Luis > Ok, thanks for sorting that out, Steve. > > > > > From ea0341e071527d5cec350917b01ab901af09d758 Mon Sep 17 00:00:00 > > 2001 From: Steven Whitehouse <swhiteho@xxxxxxxxxx> Date: Thu, 21 Nov > > 2013 18:47:57 +0000 Subject: GFS2: Fix ref count bug relating to > > atomic_open > > > > In the case that atomic_open calls finish_no_open() with > > the dentry that was supplied to gfs2_atomic_open() an > > extra reference count is required. This patch fixes that > > issue preventing a bug trap triggering at umount time. > > > > Signed-off-by: Steven Whitehouse <swhiteho@xxxxxxxxxx> > > > > diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c > > index 1615df1..7119504 100644 > > --- a/fs/gfs2/inode.c > > +++ b/fs/gfs2/inode.c > > @@ -1171,8 +1171,11 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry, > > if (d != NULL) > > dentry = d; > > if (dentry->d_inode) { > > - if (!(*opened & FILE_OPENED)) > > + if (!(*opened & FILE_OPENED)) { > > + if (d == NULL) > > + dget(dentry); > > return finish_no_open(file, dentry); > > + } > > dput(d); > > return 0; > > } > > -- > > 1.8.3.1 > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe stable" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html