Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Thursday, January 17, 2019 6:03 PM
>
> Hi Shimoda-san,
>
> CC linux-pm people
<snip>
>
> Thanks for your patch!
>
> This is similar in spirit to commits 1131b0a4af911de5 ("dmaengine:
> rcar-dmac: Make DMAC reinit during system resume explicit") and
> 73dcc666d6bd0db5 ("dmaengine: rcar-dmac: Fix too early/late system
> suspend/resume callbacks") for rcar-dmac.
>
> I'm only wondering if the "late" variant would be sufficient here.
I tried to use SET_LATE_... () instead of SET_NOIRQ_..., it also worked correctly.
> Does g_serial support wake-up?
I believe any USB gadgets don't support own system wake-up because they
are against USB host.
> Anyway, using the "noirq" variant, like you did, is probably the safest.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thank you for your review!
Best regards,
Yoshihiro Shimoda
> > ---
> > drivers/dma/sh/usb-dmac.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
> > index 7f7184c..59403f6 100644
> > --- a/drivers/dma/sh/usb-dmac.c
> > +++ b/drivers/dma/sh/usb-dmac.c
> > @@ -694,6 +694,8 @@ static int usb_dmac_runtime_resume(struct device *dev)
> > #endif /* CONFIG_PM */
> >
> > static const struct dev_pm_ops usb_dmac_pm = {
> > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> > + pm_runtime_force_resume)
> > SET_RUNTIME_PM_OPS(usb_dmac_runtime_suspend, usb_dmac_runtime_resume,
> > NULL)
> > };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
