On Sat, Jan 12, 2019 at 12:01 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Jan 11, 2019 at 04:32:12PM -0800, Gwendal Grignou wrote:
> > Prevent an empty line in /proc/self/status, allow iotop to work.
> >
> > iotop does not like empty lines, fails with:
> > File "/usr/local/lib64/python2.7/site-packages/iotop/data.py", line
> > 196, in parse_proc_pid_status
> > key, value = line.split(':\t', 1)
> > ValueError: need more than 1 value to unpack
> >
> > [reading /proc/self/status]
> >
> > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> > ---
> > fs/proc/array.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Why send this to me? Always use scripts/get_maintainer.pl on a patch to
> determine who and what lists to send patches to.
I did, your email address is on the first line:
./scripts/get_maintainer.pl
0001-CHROMIUM-FIXUP-proc-Provide-details-on-speculation-f.patch
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (commit_signer:6/4=100%)
"Srivatsa S. Bhat" <srivatsa@xxxxxxxxxxxxx> (commit_signer:3/4=75%)
Thomas Gleixner <tglx@xxxxxxxxxxxxx>
(commit_signer:3/4=75%,authored:1/4=25%,added_lines:3/28=11%)
David Woodhouse <dwmw@xxxxxxxxxxxx> (commit_signer:3/4=75%)
Bo Gan <ganb@xxxxxxxxxx> (commit_signer:3/4=75%)
Kees Cook <keescook@xxxxxxxxxxxx> (authored:1/4=25%,added_lines:23/28=82%)
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
(authored:1/4=25%,removed_lines:1/2=50%)
Gwendal Grignou <gwendal@xxxxxxxxxxxx> (authored:1/4=25%,removed_lines:1/2=50%)
linux-kernel@xxxxxxxxxxxxxxx (open list)
>
> And is this a new bug? What commit caused this?
It is only in 4.4 stable. It has been introduced by:
"484964fa3e5a0 proc: Provide details on speculation flaw mitigations"
That patch adds an extra \n in front of "Speculation Store Bypass"
that breaks iotop processing of /proc/../status.
Regards,
Gwendal.
>
> thanks,
>
> greg k-h
