Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 08, 2019 at 06:39:02PM +0000, Adit Ranadive wrote:

> >> Not sure if I follow you. We can post a failure but that would be 
> >> in pvrdma_qp.c when it looks at the opcode returned from here. We 
> >> would have to handle all the IB enums here though if you don't want 
> >> a default case (you would get compiler warnings otherwise).  
> > 
> > You'd do something like
> > 
> > default:
> >    return PVRDMA_WR_ERROR;
> > 
> > And something, somewhere, should fail the posting.
> > 
> > Jason
> > 
> 
> Okay. So maybe something like this, would work:

Yes, this is what I was thinking, please send a patch

Jason



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux