On 12/28/18 9:34 AM, Jonathan Corbet wrote: >> >> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> >> Signed-off-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> >> --- >> Documentation/admin-guide/spectre.rst | 502 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 502 insertions(+) >> create mode 100644 Documentation/admin-guide/spectre.rst > > I only saw this now, seems I wasn't copied... I'll take a deeper look, but Thanks for taking a look. I'll make sure you are copied on the updates. > I have a couple of meta comments: > > - This could arguably go in the security book rather than the admin > guide. I don't really have a strong opinion on which is right at the > moment, but others might. Since l1tf.rst is already here in admin guide, that's why I keep spectre.rst here as well. > > - Wherever it ends up, can you also please add it to the appropriate > index.rst file so it actually gets built with the rest of the docs? Yes, index.rst needs update too. Thanks. Tim