Re: [PATCH 4.14 4/4] netfilter: nf_conncount: fix garbage collection confirm race

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 2, 2019 at 3:06 PM Florian Westphal <fw@xxxxxxxxx> wrote:
>
> Mauricio Faria de Oliveira <mfo@xxxxxxxxxxxxx> wrote:
> > +static const struct nf_conntrack_tuple_hash *
> > +find_or_evict(struct net *net, struct xt_connlimit_conn *conn)
> > +{
> > +     const struct nf_conntrack_tuple_hash *found;
> > +     unsigned long a, b;
> > +     int cpu = raw_smp_processor_id();
> > +     __s32 age;
>
> This needs to be 'u32'.  Alternatively, also backport
>
> 4cd273bb91b3001f623 ("netfilter: nf_conncount: don't skip eviction when
> age is negative").

Sure, will pick that up.  Waiting for more comments before sending a v2.


-- 
Mauricio Faria de Oliveira



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux