On Mon, 2018-12-10 at 15:18:13 UTC, Greg Kurz wrote: > Implementing rollback with goto and labels is a common practice that > leads to prettier and more maintainable code. FWIW, this design pattern > is already being used in alloc_link() a few lines below in this file. > > Do the same in setup_xsl_irq(). > > Signed-off-by: Greg Kurz <groug@xxxxxxxx> > Acked-by: Frederic Barrat <fbarrat@xxxxxxxxxxxxx> > Acked-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/759bc01586535700fbb1aaf40dd727 cheers