On Fri, Dec 21, 2018 at 05:33:47PM +0800, WANG Chao wrote: > On 12/11/18 at 12:37P, WANG Chao wrote: > > Since commit 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend > > on compiler support"), RETPOLINE has been replaced by CONFIG_RETPOLINE. > > > > Fixes: 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend on compiler support") > > Signed-off-by: WANG Chao <chao.wang@xxxxxxxxx> > > ping ... This one somehow slipped through the cracks... :-\ Ok, let's see: this could be relevant for the case when a module built with a compiler which doesn't support retpolines, gets loaded on a system which is built with retpolines. Which is pretty seldom as the majority of setups out there should have a retpoline-enabled compiler. And should not allow loading external modules anyway, but that's a different story. So, this close to the merge window, I'm inclined to delay this one after it and have it take the x86/urgent fixes path. Unless someone screams and says that patch breaks his system. I haven't seen any reports about it so far so... Thx. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)