This is a note to let you know that I've just added the patch titled bonding: don't permit to use ARP monitoring in 802.3ad to the 3.12-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: bonding-don-t-permit-to-use-arp-monitoring-in-802.3ad.patch and it can be found in the queue-3.12 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From foo@baz Thu Dec 5 16:16:37 PST 2013 From: Veaceslav Falico <vfalico@xxxxxxxxxx> Date: Tue, 12 Nov 2013 15:37:40 +0100 Subject: bonding: don't permit to use ARP monitoring in 802.3ad mode From: Veaceslav Falico <vfalico@xxxxxxxxxx> [ Upstream commit ec9f1d15db8185f63a2c3143dc1e90ba18541b08 ] Currently the ARP monitoring is not supported with 802.3ad, and it's prohibited to use it via the module params. However we still can set it afterwards via sysfs, cause we only check for *LB modes there. To fix this - add a check for 802.3ad mode in bonding_store_arp_interval. CC: Jay Vosburgh <fubar@xxxxxxxxxx> CC: Andy Gospodarek <andy@xxxxxxxxxxxxx> Signed-off-by: Veaceslav Falico <vfalico@xxxxxxxxxx> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/net/bonding/bond_sysfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/net/bonding/bond_sysfs.c +++ b/drivers/net/bonding/bond_sysfs.c @@ -587,8 +587,9 @@ static ssize_t bonding_store_arp_interva goto out; } if (bond->params.mode == BOND_MODE_ALB || - bond->params.mode == BOND_MODE_TLB) { - pr_info("%s: ARP monitoring cannot be used with ALB/TLB. Only MII monitoring is supported on %s.\n", + bond->params.mode == BOND_MODE_TLB || + bond->params.mode == BOND_MODE_8023AD) { + pr_info("%s: ARP monitoring cannot be used with ALB/TLB/802.3ad. Only MII monitoring is supported on %s.\n", bond->dev->name, bond->dev->name); ret = -EINVAL; goto out; Patches currently in stable-queue which might be from vfalico@xxxxxxxxxx are queue-3.12/af_packet-block-bh-in-prb_shutdown_retire_blk_timer.patch queue-3.12/bonding-don-t-permit-to-use-arp-monitoring-in-802.3ad.patch queue-3.12/bonding-fix-two-race-conditions-in.patch queue-3.12/bonding-rcuify-bond_set_rx_mode.patch queue-3.12/net-core-always-propagate-flag-changes-to-interfaces.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html