Re: [PATCH wireless-drivers] brcmfmac: fix roamoff=1 modparam

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stijn Tintel <stijn@xxxxxxxxxxxxx> wrote:

> When the update_connect_param callback is set, nl80211 expects the flag
> WIPHY_FLAG_SUPPORTS_FW_ROAM to be set as well. However, this flag is
> only set when modparam roamoff=0, while the callback is set
> unconditionally. Since commit 7f9a3e150ec7 this causes a warning in
> wiphy_register, which breaks brcmfmac.
> 
> Disable the update_connect_param callback when roamoff=0 to fix this.
> 
> Fixes: 7f9a3e150ec7 ("nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS")
> Cc: Stable <stable@xxxxxxxxxxxxxxx> # 4.19+
> Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>
> Signed-off-by: Stijn Tintel <stijn@xxxxxxxxxxxxx>

Should this go to 4.20? Arend?

-- 
https://patchwork.kernel.org/patch/10712383/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux