Hello Hui, On Thu, Dec 13, 2018 at 08:23:40AM +0800, Hui Wang wrote: > Hello Thomas, > > I have sent a new patch to fix this LED regression, after applying > this patch (ALSA: hda/realtek - fix the pop noise on headphone for > lenovo laptops) and the new patch (ALSA: hda/realtek - Fix the mute > LED regresion on Lenovo X1 Carbon), the issue will be fixed. > > This is the new patch I sent (also CCed to stable): > > http://mailman.alsa-project.org/pipermail/alsa-devel/2018-December/142747.html thanks, I can confirm that this fixes the LED regression. > About the noise, if you follow the steps as below, you would hear the > noticeable click/pop noise: > > 1. Hookup a set of headphones that you can separately place in/on your > ears. (ie. ear buds) > > 2. Put only the right headphone in/on your ear. > > 3. Go to the Gnome sound settings and bring up the "Test Speakers" > function > > 4. Play the left speaker test > > You would expect to hear nothing in the right ear, but instead you > hear a "pop" at the start of each word spoken. ("pop" Front "pop" > left). You can repeat with the left headphone and see similar results. > I even tried shifting the balance all the way to the left/right and > get the same results. Thank you for elaborating on the noise problem - now I could also reproduce it and see that your patch (ALSA: hda/realtek - fix the pop noise on headphone for lenovo laptops) fixes it. Regards, Thomas
