Re: [PATCH 1/3] btrfs: release metadata before running delayed refs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3.12.18 г. 17:50 ч., Sasha Levin wrote:
> On Thu, Nov 29, 2018 at 02:36:05PM +0200, Nikolay Borisov wrote:
>>
>>
>> On 29.11.18 г. 14:21 ч., Greg KH wrote:
>>> On Tue, Nov 20, 2018 at 10:11:21AM +0200, Nikolay Borisov wrote:
>>>> From: Josef Bacik <josef@xxxxxxxxxxxxxx>
>>>>
>>>> We want to release the unused reservation we have since it refills the
>>>> delayed refs reserve, which will make everything go smoother when
>>>> running the delayed refs if we're short on our reservation.
>>>>
>>>> CC: stable@xxxxxxxxxxxxxxx # 4.4+
>>>> Reviewed-by: Omar Sandoval <osandov@xxxxxx>
>>>> Reviewed-by: Liu Bo <bo.liu@xxxxxxxxxxxxxxxxx>
>>>> Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>
>>>> Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
>>>> Signed-off-by: David Sterba <dsterba@xxxxxxxx>
>>>> ---
>>>>
>>>> Hello Greg,
>>>>
>>>> Here is a fixed up backport for upstream commit
>>>> f45c752b65af46bf42963295c332865d95f97fff
>>>> This one applies cleanly to 4.4.y and 4.9.y
>>>
>>> What about 4.14.y?  I don't want to apply this to only 4.4 and 4.9 and
>>> not 4.14.  Can you provide a working backport there too?
>>
>> I've only made backports as a result of your "failed to apply" emails.
>> If there isn't a backport for 4.14 then this means it's either handled
>> or you didn't send such an email, or i wasn't cced
>>
>>>
>>> And I don't see the 2/3 patch in this series, has that already been
>>> handled?
> 
> I see commit 2/3 failed to apply on 4.9 and 4.4:
> https://www.spinics.net/lists/stable/msg267061.html would you send a
> backport for it as well?

I think not, because the memalloc_xxx_save/restore infrastructure is
missing and actually plumbing GFP flags to btrfs_iget so that in only 1
unique context we can pass GFP_NOFS will be rather invasive.

> 
> -- 
> Thanks,
> Sasha
> 



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux