Re: [PATCH] ocxl: Fix endiannes bug in read_afu_name()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/12/18 2:10 am, Greg Kurz wrote:
The double word returned by read_afu_info(OCXL_DVSEC_TEMPL_NAME) contains
four characters of the AFU name, read from the PCI config space, hence
with a little-endian ordering. When composing the string, a big-endian
system must swap the bytes so that the characters appear in the right
order.

Do this with le32_to_cpu().

Signed-off-by: Greg Kurz <groug@xxxxxxxx>

snowpatch reports the following sparse warning:

+drivers/misc/ocxl/config.c:321:24: warning: cast to restricted __le32

You probably need to change val from a u32 to a __le32.

---
  drivers/misc/ocxl/config.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c
index 57a6bb1fd3c9..b76198ba8630 100644
--- a/drivers/misc/ocxl/config.c
+++ b/drivers/misc/ocxl/config.c
@@ -318,7 +318,7 @@ static int read_afu_name(struct pci_dev *dev, struct ocxl_fn_config *fn,
  		if (rc)
  			return rc;
  		ptr = (u32 *) &afu->name[i];
-		*ptr = val;
+		*ptr = le32_to_cpu(val);
  	}
  	afu->name[OCXL_AFU_NAME_SZ - 1] = '\0'; /* play safe */
  	return 0;


--
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@xxxxxxxxxxx  IBM Australia Limited




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux