Re: [PATCH 3/3] xfrm: Fix null pointer dereference when decoding sessions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ccing stable.

On Sun, Dec 01, 2013 at 08:35:06PM -0500, David Miller wrote:
> From: Matthias Schiffer <mschiffer@xxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 01 Dec 2013 05:19:53 +0100
> 
> > On 11/24/2013 03:27 PM, Matthias Schiffer wrote:
> >> On 11/01/2013 09:21 AM, Steffen Klassert wrote:
> >>> On some codepaths the skb does not have a dst entry
> >>> when xfrm_decode_session() is called. So check for
> >>> a valid skb_dst() before dereferencing the device
> >>> interface index. We use 0 as the device index if
> >>> there is no valid skb_dst(), or at reverse decoding
> >>> we use skb_iif as device interface index.
> >>>
> >>> Bug was introduced with git commit bafd4bd4dc
> >>> ("xfrm: Decode sessions with output interface.").
> >>>
> >>> Reported-by: Meelis Roos <mroos@xxxxxxxx>
> >>> Tested-by: Meelis Roos <mroos@xxxxxxxx>
> >>> Signed-off-by: Steffen Klassert <steffen.klassert@xxxxxxxxxxx>
> >> 
> >> Please queue this for 3.12-stable, I've seen this bug trigger a panic
> >> when heavily using Bittorrent (screenshot:
> >> http://i.imgur.com/OIKVccM.jpg )
> >> 
> >> Thanks,
> >> Matthias
> >> 
> > 
> > Ping? Several people I know have hit this panic with 3.12.x at least
> > once or twice by now during heavy IPv6 usage.
> 
> Steffen submitted it to stable@xxxxxxxxxxxxxxx for inclusion on Monday
> November 25th.

It apparently did not make it into v3.12.2 and it is not in the v3.12.3
review included. So I wonder if I need to do anything additional to
get it included. It is the first time that I did a stable submission
myself.

I tried to follow the instructions at Documentation/stable_kernel_rules.txt
but maybe I've missed something.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]