On 06/12/2018 04:17, Martin K. Petersen wrote: +
Bart,Had you considered to use lower_32_bits() instead of "0xffffffff"? That would to avoid that reviewers have to count the 'f'-s to verify correctness of t10_pi_ref_tag().I hadn't. I guess I tend to think of lower_32_bits() as something you do to pointers, not to block numbers.
Xiang Chen tested the patch successfully. I'll let him provide tested-by tag.
Thanks, John
