Hi, As I've already fed back to Sascha about this, this patch on its own does not fix anything, and is not a stable kernel candidate without a patch that makes use of it (iow, the spectre fixes.) It is a preparatory patch for mainline commit 383fb3ee8024. Every commit in: $ git rev-list v4.16..383fb3ee8024 are the ARM spectre fixes, which are being back-ported by David Long. Please do not cherry-pick commits from within this series for _any_ stable kernel, but please wait for David to send you the back-ported patches. Thanks. On Thu, Nov 29, 2018 at 03:11:32PM +0100, Greg Kroah-Hartman wrote: > 3.18-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ] > > Move lookup_processor_type() out of the __init section so it is callable > from (eg) the secondary startup code during hotplug. > > Reviewed-by: Julien Thierry <julien.thierry@xxxxxxx> > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > --- > arch/arm/kernel/head-common.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S > index 8733012d231f..7e662bdd5cb3 100644 > --- a/arch/arm/kernel/head-common.S > +++ b/arch/arm/kernel/head-common.S > @@ -122,6 +122,9 @@ __mmap_switched_data: > .long init_thread_union + THREAD_START_SP @ sp > .size __mmap_switched_data, . - __mmap_switched_data > > + __FINIT > + .text > + > /* > * This provides a C-API version of __lookup_processor_type > */ > @@ -133,9 +136,6 @@ ENTRY(lookup_processor_type) > ldmfd sp!, {r4 - r6, r9, pc} > ENDPROC(lookup_processor_type) > > - __FINIT > - .text > - > /* > * Read processor ID register (CP#15, CR0), and look up in the linker-built > * supported processor list. Note that we can't use the absolute addresses > -- > 2.17.1 > > > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up