Re: [PATCH v4.4] iwlwifi: mvm: fix regulatory domain update when the firmware starts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-11-29 at 11:25 +0100, Greg KH wrote:
> On Thu, Nov 29, 2018 at 10:43:52AM +0200, Luca Coelho wrote:
> > From: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> > 
> > When the firmware starts, it doesn't have any regulatory
> > information, hence it uses the world wide limitations. The
> > driver can feed the firmware with previous knowledge that
> > was kept in the driver, but the firmware may still not
> > update its internal tables.
> > 
> > This happens when we start a BSS interface, and then the
> > firmware can change the regulatory tables based on our
> > location and it'll use more lenient, location specific
> > rules. Then, if the firmware is shut down (when the
> > interface is brought down), and then an AP interface is
> > created, the firmware will forget the country specific
> > rules.
> > 
> > The host will think that we are in a certain country that
> > may allow channels and will try to teach the firmware about
> > our location, but the firmware may still not allow to drop
> > the world wide limitations and apply country specific rules
> > because it was just re-started.
> > 
> > In this case, the firmware will reply with MCC_RESP_ILLEGAL
> > to the MCC_UPDATE_CMD. In that case, iwlwifi needs to let
> > the upper layers (cfg80211 / hostapd) know that the channel
> > list they know about has been updated.
> > 
> > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=201105
> > 
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
> > ---
> >  drivers/net/wireless/iwlwifi/mvm/mac80211.c | 8 ++++++--
> >  drivers/net/wireless/iwlwifi/mvm/nvm.c      | 5 ++---
> >  2 files changed, 8 insertions(+), 5 deletions(-)
> 
> You forgot the git commit id :(

Ouch! Sorry about that...


> I dug it up and queued this up now.

Thanks, Greg!

--
Cheers,
Luca.




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux