On Thu, Nov 15, 2018 at 10:39:44AM +0000, Leonard Crestez wrote:
On Wed, 2018-11-14 at 17:21 -0500, Sasha Levin wrote:From: Leonard Crestez <leonard.crestez@xxxxxxx> [ Upstream commit 1ad9fb750a104f51851c092edd7b3553f0218428 ] Bindings for "fixed-regulator" only explicitly support "gpio" property, not "gpios". Fix by correcting the property name. The enet PHYs on imx6sx-sdb needs to be explicitly reset after a power cycle, this can be handled by the phy-reset-gpios property. Sadly this is not handled on suspend: the fec driver turns phy-supply off but doesn't assert phy-reset-gpios again on resume. Since additional phy-level work is required to support powering off the phy in suspend fix the problem by just marking the regulator as "boot-on" "always-on" so that it's never turned off. This behavior is equivalent to older releases. Keep the phy-reset-gpios property on fec anyway because it is a correct description of board design. This issue was exposed by commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor only") which causes the "gpios" property to also be parsed. Before that commit the "gpios" property had no effect, PHY reset was only handled in the the bootloader. Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx> Signed-off-by: Shawn Guo <shawnguo@xxxxxxxxxx>This is something of a workaround for gpio core changes in 4.20 and there is no need for it in older releases. I don't think you should backport this.
Dropped, thank you. Thanks, Sasha
