Re: Please revert "ACPICA: AML interpreter: add region addresses in global list during initialization"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 20, 2018 at 09:46:49AM +0100, Jean Delvare wrote:
> Dear stable kernel team,
> 
> In stable kernel 4.19.2, the following upstream commit was included:
> 
> commit 4abb951b73ff0a8a979113ef185651aa3c8da19b
> Author: Erik Schmauss
> Date:   Wed Oct 17 14:09:35 2018 -0700
> 
>     ACPICA: AML interpreter: add region addresses in global list during initialization
> 
> This commit was tagged with:
> 
>     Link: https://bugzilla.kernel.org/show_bug.cgi?id=200011
>     Tested-by: Jean-Marc Lenoir
>     Cc: All applicable <stable@xxxxxxxxxxxxxxx>
> 
> making it sound like it was fixing an actual bug. This is not the case.
> The commit fixes a side issue discovered while investigating bug
> #200011. It does NOT fix bug #200011 itself (as explicitly reported by
> Jean-Marc at https://bugzilla.kernel.org/show_bug.cgi?id=200011#c65 ).
> 
> It does however cause regressions, despite what the commit message says. See:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=201721
> 
> and I expect more similar regressions, as ACPI resource conflicts are
> very frequent.
> 
> This commit was not stable material to start with. It is intrusive,
> presents a risk of side effects, and does not solve an actual bug that
> is bothering users.
> 
> Please revert this commit from future stable kernels on all affected
> branches (I think only 4.18.19 and 4.19.2 are affected at the moment,
> but maybe other affected releases are in the works already).

Ok, I'll go revert this, but shouldn't it also be reverted in Linus's
tree as well?

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux