Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race condition and leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On 31/10/2018 19:12:06-0400, Sasha Levin wrote:
> -	m->rtc = rtc_device_register(DRIVER_NAME,
> -			&m->client->dev,
> -			&menelaus_rtc_ops, THIS_MODULE);
> -	if (IS_ERR(m->rtc)) {
> +	err = rtc_register_device(m->rtc);

This appeared in v4.13, this will not compile on v3.18.

> +	if (err) {
>  		if (alarm) {
>  			menelaus_remove_irq_work(MENELAUS_RTCALM_IRQ);
>  			device_init_wakeup(&m->client->dev, 0);
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux