Re: [PATCH] kbuild: set no-integrated-as before incl. arch Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 29, 2018 at 10:39 AM Stefan Agner <stefan@xxxxxxxx> wrote:
>
> Hi,
>
> On 29.10.2018 18:08, ndesaulniers@xxxxxxxxxx wrote:
> > From: Stefan Agner <stefan@xxxxxxxx>
> >
> > In order to make sure compiler flag detection for ARM works
> > correctly the no-integrated-as flags need to be set before
> > including the arch specific Makefile.
> >
> > commit 0f0e8de334c54c38818a4a5390a39aa09deff5bf upstream
>
> That is already queued, it got selected just a few days ago:
>
> https://lkml.org/lkml/2018/10/25/581

Cool, thanks for the link and the fix in the first place. Just following up on:
https://github.com/ClangBuiltLinux/linux/issues/25

>
> --
> Stefan
>
> >
> > Fixes: cfe17c9bbe6a ("kbuild: move cc-option and cc-disable-warning
> > after incl. arch Makefile")
> > Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > Reported-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> > ---
> > Sending to stable for inclusion in 4.14. Needed for
> > CONFIG_ARM64_LSE_ATOMICS.
> >
> >
> >  Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index e02d092bc2d6..9e7f69c26aba 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -487,6 +487,8 @@ CLANG_GCC_TC      := --gcc-toolchain=$(GCC_TOOLCHAIN)
> >  endif
> >  KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
> >  KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
> > +KBUILD_CFLAGS += $(call cc-option, -no-integrated-as)
> > +KBUILD_AFLAGS += $(call cc-option, -no-integrated-as)
> >  endif
> >
> >  RETPOLINE_CFLAGS_GCC := -mindirect-branch=thunk-extern
> > -mindirect-branch-register
> > @@ -743,8 +745,6 @@ KBUILD_CFLAGS += $(call cc-disable-warning,
> > tautological-compare)
> >  # See modpost pattern 2
> >  KBUILD_CFLAGS += $(call cc-option, -mno-global-merge,)
> >  KBUILD_CFLAGS += $(call cc-option, -fcatch-undefined-behavior)
> > -KBUILD_CFLAGS += $(call cc-option, -no-integrated-as)
> > -KBUILD_AFLAGS += $(call cc-option, -no-integrated-as)
> >  else
> >
> >  # These warnings generated too much noise in a regular build.



-- 
Thanks,
~Nick Desaulniers



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux