Re: [PATCH] [fs] exportfs/expfs.c Validate the dentry in exportfs_decode_fh function

[Amir Goldstein <amir73il@xxxxxxxxx>]

On Sun, Oct 21, 2018 at 10:26 AM Monthero <rhmcruiser@xxxxxxxxx> wrote:
>
> Hi Amir thanks for the pointer.
> I will get in touch with maintainer of 3.16
> Yes it covers Neil's commit and apart from that it would  need this replacement for dentry check in 3.16
>
> > -       if (S_ISDIR(result->d_inode->i_mode)) {
> > +       if (d_is_dir(result)) {
>

Fine, but Why?
How is dereferencing dentry->d_flags any better than dereferencing->d_inode
when dentry has an invalid value?

Thanks,
Amir.