On Thu, Oct 18, 2018 at 5:04 PM Natanael Copa <ncopa@xxxxxxxxxxxxxxx> wrote: > > Commit b6cc0ba2cbf4 (HID: add support for Apple Magic Keyboards) > backported support for the Magic Keyboard over Bluetooth, but did not > add the BT_VENDOR_ID_APPLE to hid_have_special_driver[] so the hid-apple > driver is never loaded and Fn key does not work at all. > > Adding BT_VENDOR_ID_APPLE to hid_have_special_driver[] is not needed > after commit e04a0442d33b (HID: core: remove the absolute need of > hid_have_special_driver[]), so 4.16 kernels and newer does not need it. > > Fixes: b6cc0ba2cbf4 (HID: add support for Apple Magic Keyboards) > Bugzilla-id: https://bugzilla.kernel.org/show_bug.cgi?id=99881 > Signed-off-by: Natanael Copa <ncopa@xxxxxxxxxxxxxxx> > --- Acked-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > > Benjamin, thank you for your help with this. you're welcome :) Cheers, Benjamin > > I believe this is needed for both linux-4.14.y and linux-4.9.y. > > drivers/hid/hid-core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 672b0be41d44..a306493e2e97 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -1964,6 +1964,9 @@ static const struct hid_device_id hid_have_special_driver[] = { > { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ISO) }, > { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_JIS) }, > { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI) }, > + { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI) }, > + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_ANSI) }, > + { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_ANSI) }, > { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY) }, > { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY) }, > #endif > -- > 2.19.1 >
