On Fri, Oct 12, 2018 at 01:41:35PM -0600, Ross Zwisler wrote: > From: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> > > commit 1208d8a84fdcae6b395c57911cdf907450d30e70 upstream. > > When disabling a USB3 port the hub driver will set the port link state to > U3 to prevent "ejected" or "safely removed" devices that are still > physically connected from immediately re-enumerating. > > If the device was really unplugged, then error messages were printed > as the hub tries to set the U3 link state for a port that is no longer > enabled. > > xhci-hcd ee000000.usb: Cannot set link state. > usb usb8-port1: cannot disable (err = -32) > > Don't print error message in xhci-hub if hub tries to set port link state > for a disabled port. Return -ENODEV instead which also silences hub driver. > > Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> > Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Ross Zwisler <zwisler@xxxxxxxxxx> > --- > > We'd like to get this commit added to linux-4.14.y, linux-4.9.y and > linux-4.4.y, please. We continue to get error reports from users who > are concerned about the USB error messages referred to in the changelog. > > The upstream commit 1208d8a84fdc can be cherry-picked cleanly to > linux-4.14.y, and this patch applies cleanly to both linux-4.9.y and > linux-4.4.y. I've tested both the clean cherry-pick and this version > of the patch on real hardware. Now applied, thanks. greg k-h
