Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/2013 12:24 PM, Matthew Garrett wrote:
On Wed, Nov 27, 2013 at 12:18:28PM -0700, Khalid Aziz wrote:

+/* flag to track if kexec reboot is in progress */
+extern unsigned long kexec_in_progress;

Adding this to pci.h seems a little odd. We may want to use it somewhere
else at some point. Add it to kexec.h instead?


I debated between pci.h and kexec.h but pci-driver.c does not include kexec.h and I didn't want to include a whole new file. Now I see another problem with adding that extern declaration to pci.h - if CONFIG_KEXEC is not set, build will fail. I should add #ifdef CONFIG_KEXEC to the code in pci-driver.c as well. Time for v2.

--
Khalid
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]