On Tue, Oct 09, 2018 at 05:29:20PM +0200, Kleber Sacilotto de Souza wrote:
> Hi Greg,
>
> The backport of upstream commit 1bd6a1c4b80a ("powerpc/fadump: handle
> crash memory ranges array index overflow") introduced a ppc build failure
> on 4.4-stable and 4.9-stable when CONFIG_FA_DUMP is enabled:
>
> arch/powerpc/kernel/fadump.c: In function ‘register_fadump’:
> arch/powerpc/kernel/fadump.c:1015:10: error: ‘return’ with a value, in function returning void [-Werror]
> return ret;
> ^~~
> arch/powerpc/kernel/fadump.c:1000:13: note: declared here
> static void register_fadump(void)
> ^~~~~~~~~~~~~~~
>
> I am suggesting to fix it by backporting 98b8cd7f7564 ("powerpc/fadump:
> Return error when fadump registration fails"), which is an earlier
> commit that (among other things) set the return of register_fadump() to
> int and has little functional changes. It was applied upstream for
> v4.13, so 4.14-stable and later are already fixed.
Now fixed up, thanks.
greg k-h
