On Tue, Oct 09, 2018 at 02:07:15PM +0100, Ignat Korchagin wrote: > Hello, > > We were trying to build 4.14 kernel with GCC 8, but perf failed to > compile. The upstream tree seems to have necessary commits to support > GCC 8, but they were not ported to 4.14 branch. With backporting the > following commits we were able to restore perf compilation and compile > a working 4.14 kernel with GCC 8.2: > > 6810158d526e483868e519befff407b91e76b3db: perf annotate: Use asprintf > when formatting objdump command > b7a313d84e853049062011d78cb04b6decd12f5c: perf tools: Fix python > extension build for gcc 8 > 77f18153c080855e1c3fb520ca31a4e61530121d: perf tools: Fix snprint > warnings for gcc 8 > 06c3f2aa9fc68e7f3fe3d83e7569d2a2801d9f99: perf utils: Move > is_directory() to path.h Why is this last commit needed? I've applied the other 3 now. thanks, greg k-h