On Thu, 2018-10-04 at 16:56 -0700, Dan Williams wrote: > The driver is only initializing bb_res in the devm_memremap_pages() > paths, but the raw namespace case is passing an uninitialized bb_res > to > nvdimm_badblocks_populate(). > > Fixes: e8d513483300 ("memremap: change devm_memremap_pages > interface...") > Cc: <stable@xxxxxxxxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Reported-by: Jacek Zloch <jacek.zloch@xxxxxxxxx> > Reported-by: Krzysztof Rusocki <krzysztof.rusocki@xxxxxxxxx> > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> > --- > drivers/nvdimm/pmem.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 6071e2942053..2082ae01b9c8 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -421,9 +421,11 @@ static int pmem_attach_disk(struct device *dev, > addr = devm_memremap_pages(dev, &pmem->pgmap); > pmem->pfn_flags |= PFN_MAP; > memcpy(&bb_res, &pmem->pgmap.res, sizeof(bb_res)); > - } else > + } else { > addr = devm_memremap(dev, pmem->phys_addr, > pmem->size, ARCH_MEMREMAP_PMEM); > + memcpy(&bb_res, &nsio->res, sizeof(bb_res)); > + } Good find! Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>