This is a note to let you know that I've just added the patch titled NFSv4: don't fail on missing fattr in open recover to the 3.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: nfsv4-don-t-fail-on-missing-fattr-in-open-recover.patch and it can be found in the queue-3.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From a43ec98b72aae3e330f0673438f58316c3769b84 Mon Sep 17 00:00:00 2001 From: Weston Andros Adamson <dros@xxxxxxxxxx> Date: Mon, 21 Oct 2013 13:10:11 -0400 Subject: NFSv4: don't fail on missing fattr in open recover From: Weston Andros Adamson <dros@xxxxxxxxxx> commit a43ec98b72aae3e330f0673438f58316c3769b84 upstream. This is an unneeded check that could cause the client to fail to recover opens. Signed-off-by: Weston Andros Adamson <dros@xxxxxxxxxx> Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/nfs/nfs4proc.c | 6 ------ 1 file changed, 6 deletions(-) --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -1165,12 +1165,6 @@ _nfs4_opendata_reclaim_to_nfs4_state(str goto err; } - ret = -ESTALE; - if (!(data->f_attr.valid & NFS_ATTR_FATTR_TYPE) || - !(data->f_attr.valid & NFS_ATTR_FATTR_FILEID) || - !(data->f_attr.valid & NFS_ATTR_FATTR_CHANGE)) - goto err; - ret = -ENOMEM; state = nfs4_get_open_state(inode, data->owner); if (state == NULL) Patches currently in stable-queue which might be from dros@xxxxxxxxxx are queue-3.10/nfsv4-fix-a-use-after-free-situation-in-_nfs4_proc_getlk.patch queue-3.10/nfsv4-fix-null-dereference-in-open-recover.patch queue-3.10/nfsv4-don-t-reprocess-cached-open-claim_previous.patch queue-3.10/sunrpc-don-t-map-ekeyexpired-to-eacces-in-call_refreshresult.patch queue-3.10/nfsv4-don-t-fail-on-missing-fattr-in-open-recover.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html