Re: [PATCH] Revert "uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-09-24 at 13:00 +0100, David Howells wrote:
> Lubomir Rintel <lkundrak@xxxxx> wrote:
> 
> > This changes UAPI, breaking iwd and libell:
> > 
> >   ell/key.c: In function 'kernel_dh_compute':
> >   ell/key.c:205:38: error: 'struct keyctl_dh_params' has no member
> > named 'private'; did you mean 'dh_private'?
> >     struct keyctl_dh_params params = { .private = private,
> >                                         ^~~~~~~
> >                                         dh_private
> > 
> > This reverts commit 8a2336e549d385bb0b46880435b411df8d8200e8.
> > 
> > Cc: David Howells <dhowells@xxxxxxxxxx>
> > Cc: James Morris <jmorris@xxxxxxxxx>
> > Cc: "Serge E. Hallyn" <serge@xxxxxxxxxx>
> > Cc: Mat Martineau <mathew.j.martineau@xxxxxxxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx>
> 
> Can I stick your Signed-off-by on it?

   1. Yes, please do.

Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>

> 
> David




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux