Re: [PATCH 4.14-4.17 1/2] earlycon: Initialize port->uartclk based on clock-frequency property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 24, 2018 at 12:34:45AM +0200, Rafał Miłecki wrote:
> From: Michal Simek <michal.simek@xxxxxxxxxx>
> 
> commit 814453adea7d081ad8917aa0f32d6a14165a3563 upstream.
> 
> On DT based platforms when current-speed property is present baudrate
> is setup. Also port->uartclk is initialized to bogus BASE_BAUD * 16
> value. Drivers like uartps/ns16550 contain logic when baudrate and
> uartclk is used for baudrate calculation.
> 
> The patch is reading optional clock-frequency property to replace bogus
> BASE_BAUD * 16 calculation to have proper baudrate calculation.
> 
> [-stable comment: commit 31cb9a8575ca ("earlycon: initialise baud field
>  of earlycon device structure") has changed 8250_early.c behavior which
>  now tries to setup UART speed. Ignoring clock-frequency results in
>  wrong value of calculated divisor & malformed early console output.]

Thanks for both of these, now queued up.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux