On Tue, Sep 18, 2018 at 12:00:51PM +0100, Will Deacon wrote: >On Tue, Sep 18, 2018 at 06:55:34AM -0400, Mikulas Patocka wrote: >> This patch is not correct, because the stacktrace is supposed to work >> around discontiguous interrupt stacks. >> >> You should replace 'frame->fp <= fp' with 'frame->fp == fp'. > >No, just drop the patch. It was already reverted upstream in >e87a4a92fba3. Can the AUTOSEL robot check for upstream reverts? It does! Once when it grabs the patch and once right before Greg sees a pull request. There's a (rather large - ~2 week) time gap in between when fixes/reverts sneak in. Thanks for the review, I'll drop the patch. -- Thanks, Sasha
