oh, good catch! will fix and respin in just a little bit On Wed, 2018-09-19 at 22:38 +0200, Julia Lawall wrote: > Hello, > > I don't think you can update the loop index variable in > list_for_each_entry, because the mcro uses th index variable to get to the > next element. Perhaps list_for_each_entry_safe would be more suitable? > > julia > > ---------- Forwarded message ---------- > Date: Thu, 20 Sep 2018 04:30:13 +0800 > From: kbuild test robot <lkp@xxxxxxxxx> > To: kbuild@xxxxxx > Cc: Julia Lawall <julia.lawall@xxxxxxx> > Subject: Re: [PATCH 1/6] drm/dp_mst: Introduce > drm_dp_mst_connector_atomic_check() > > CC: kbuild-all@xxxxxx > In-Reply-To: <20180918230637.20700-2-lyude@xxxxxxxxxx> > References: <20180918230637.20700-2-lyude@xxxxxxxxxx> > TO: Lyude Paul <lyude@xxxxxxxxxx> > CC: dri-devel@xxxxxxxxxxxxxxxxxxxxx, nouveau@xxxxxxxxxxxxxxxxxxxxx, > intel-gfx@xxxxxxxxxxxxxxxxxxxxx, amd-gfx@xxxxxxxxxxxxxxxxxxxxx > CC: David Airlie <airlied@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, > stable@xxxxxxxxxxxxxxx, Sean Paul <sean@xxxxxxxxxx> > > Hi Lyude, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on drm-intel/for-linux-next] > [also build test WARNING on v4.19-rc4 next-20180919] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system] > > url: > https://github.com/0day-ci/linux/commits/Lyude-Paul/Fix-legacy-DPMS-changes-with-MST/20180919-203434 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > :::::: branch date: 8 hours ago > :::::: commit date: 8 hours ago > > > > drivers/gpu/drm/drm_dp_mst_topology.c:3144:1-20: iterator with update on > > > line 3145 > > # > https://github.com/0day-ci/linux/commit/f8df31d5221b9a6da6698d4a37e622253bb17cdc > git remote add linux-review https://github.com/0day-ci/linux > git remote update linux-review > git checkout f8df31d5221b9a6da6698d4a37e622253bb17cdc > vim +3144 drivers/gpu/drm/drm_dp_mst_topology.c > > 3f3353b7 Pandiyan, Dhinakaran 2017-04-20 3131 > f8df31d5 Lyude Paul 2018-09-18 3132 static bool > f8df31d5 Lyude Paul 2018-09- > 18 3133 drm_dp_mst_connector_still_exists(struct drm_connector *connector, > f8df31d5 Lyude Paul 2018-09-18 3134 > struct drm_dp_mst_topology_mgr *mgr, > f8df31d5 Lyude Paul 2018-09-18 3135 > struct drm_dp_mst_branch *mstb) > f8df31d5 Lyude Paul 2018-09-18 3136 { > f8df31d5 Lyude Paul 2018-09-18 3137 struct drm_dp_mst_port > *port; > f8df31d5 Lyude Paul 2018-09-18 3138 bool exists = false; > f8df31d5 Lyude Paul 2018-09-18 3139 > f8df31d5 Lyude Paul 2018-09-18 3140 mstb = > drm_dp_get_validated_mstb_ref(mgr, mstb); > f8df31d5 Lyude Paul 2018-09-18 3141 if (!mstb) > f8df31d5 Lyude Paul 2018-09-18 3142 return false; > f8df31d5 Lyude Paul 2018-09-18 3143 > f8df31d5 Lyude Paul 2018-09-18 @3144 list_for_each_entry(port > , &mstb->ports, next) { > f8df31d5 Lyude Paul 2018-09-18 @3145 port = > drm_dp_get_validated_port_ref(mgr, port); > f8df31d5 Lyude Paul 2018-09-18 3146 if (!port) > f8df31d5 Lyude Paul 2018-09-18 3147 continue > ; > f8df31d5 Lyude Paul 2018-09-18 3148 > f8df31d5 Lyude Paul 2018-09-18 3149 exists = (port- > >connector == connector || > f8df31d5 Lyude Paul 2018-09-18 3150 (port- > >mstb && > f8df31d5 Lyude Paul 2018-09-18 3151 drm_d > p_mst_connector_still_exists(connector, mgr, > f8df31d5 Lyude Paul 2018-09-18 3152 > port->mstb))); > f8df31d5 Lyude Paul 2018-09-18 3153 > f8df31d5 Lyude Paul 2018-09-18 3154 drm_dp_put_port( > port); > f8df31d5 Lyude Paul 2018-09-18 3155 if (exists) > f8df31d5 Lyude Paul 2018-09-18 3156 break; > f8df31d5 Lyude Paul 2018-09-18 3157 } > f8df31d5 Lyude Paul 2018-09-18 3158 > f8df31d5 Lyude Paul 2018-09-18 3159 drm_dp_put_mst_branch_de > vice(mstb); > f8df31d5 Lyude Paul 2018-09-18 3160 return exists; > f8df31d5 Lyude Paul 2018-09-18 3161 } > f8df31d5 Lyude Paul 2018-09-18 3162 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation
