This is a note to let you know that I've just added the patch titled
ACPI / hotplug: Fix handle_root_bridge_removal()
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-hotplug-fix-handle_root_bridge_removal.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 2441191a19039002b2c454a261fb45986df15184 Mon Sep 17 00:00:00 2001
From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
Date: Thu, 7 Nov 2013 01:41:27 +0100
Subject: ACPI / hotplug: Fix handle_root_bridge_removal()
From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
commit 2441191a19039002b2c454a261fb45986df15184 upstream.
It is required to do get_device() on the struct acpi_device in
question before passing it to acpi_bus_hot_remove_device() through
acpi_os_hotplug_execute(), because acpi_bus_hot_remove_device()
calls acpi_scan_hot_remove() that does put_device() on that
object.
The ACPI PCI root removal routine, handle_root_bridge_removal(),
doesn't do that, which may lead to premature freeing of the
device object or to executing put_device() on an object that
has been freed already.
Fix this problem by making handle_root_bridge_removal() use
get_device() as appropriate.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Acked-by: Toshi Kani <toshi.kani@xxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/acpi/pci_root.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -614,9 +614,12 @@ static void handle_root_bridge_removal(s
ej_event->device = device;
ej_event->event = ACPI_NOTIFY_EJECT_REQUEST;
+ get_device(&device->dev);
status = acpi_os_hotplug_execute(acpi_bus_hot_remove_device, ej_event);
- if (ACPI_FAILURE(status))
+ if (ACPI_FAILURE(status)) {
+ put_device(&device->dev);
kfree(ej_event);
+ }
}
static void _handle_hotplug_event_root(struct work_struct *work)
Patches currently in stable-queue which might be from rafael.j.wysocki@xxxxxxxxx are
queue-3.10/acpi-ec-ensure-lock-is-acquired-before-accessing-ec-struct-members.patch
queue-3.10/acpica-fix-for-a-store-argx-when-argx-contains-a-reference-to-a-field.patch
queue-3.10/acpica-derefof-operator-update-to-fully-resolve-fieldunit-and-bufferfield-refs.patch
queue-3.10/acpi-hotplug-fix-handle_root_bridge_removal.patch
queue-3.10/acpica-return-error-if-derefof-resolves-to-a-null-package-element.patch
queue-3.10/acpi-video-quirk-initial-backlight-level-0.patch
queue-3.10/acpi-hotplug-do-not-execute-insert-in-progress-_ost.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html