On Fri, Sep 07, 2018 at 12:37:22AM +0000, Sasha Levin wrote: > From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > > [ Upstream commit 6f3fde684d0232e66ada3410f016a58e09a87689 ] > > The USB completion callback does not disable interrupts while acquiring > the lock. We want to remove the local_irq_disable() invocation from > __usb_hcd_giveback_urb() and therefore it is required for the callback > handler to disable the interrupts while acquiring the lock. > The callback may be invoked either in IRQ or BH context depending on the > USB host controller. > Use the _irqsave() variant of the locking primitives. > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx> > --- > drivers/usb/misc/usbtest.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Again, this can be dropped. thanks, greg k-h
