Re: [PATCH] Fixes: Commit 2aa6d036b716 ("mm: numa: avoid waiting on freed migrated pages")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 5, 2018 at 11:03 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Sep 05, 2018 at 10:43:17AM -0400, Chas Williams wrote:
> > From: Chas Williams <chas3@xxxxxxx>
> >
> > Commit 2aa6d036b716 ("mm: numa: avoid waiting on freed migrated pages")
> > was an incomplete backport of the upstream commit.  It is necessary to
> > always reset page_nid before attempting any early exit.
> >
> > The original commit conflicted due to lack of commit 82b0f8c39a38
> > ("mm: join struct fault_env and vm_fault") in 4.9 so it wasn't a clean
> > application, and the change must have just gotten lost in the noise.
> >
> > Signed-off-by: Chas Williams <chas3@xxxxxxx>
> > ---
> >  mm/huge_memory.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Much better, thanks!
>
> But can you cc: the people involved in that first patch to get their
> ack?
>
> Also, what about 4.4.y and 3.18.y which had the original commit
> backported as well?  Do they also need this fix?

Yes, both are broken.

> thanks,
>
> greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux