On Thu, Aug 16, 2018 at 2:17 PM, Ghannam, Yazen <Yazen.Ghannam@xxxxxxx> wrote: >> -----Original Message----- >> From: Michael Jin <mikhail.jin@xxxxxxxxx> >> Sent: Wednesday, August 15, 2018 6:41 AM >> To: Borislav Petkov <bp@xxxxxxx>; Ghannam, Yazen >> <Yazen.Ghannam@xxxxxxx>; Mauro Carvalho Chehab >> <mchehab@xxxxxxxxxx> >> Cc: linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Michael Jin >> <mikhail.jin@xxxxxxxxx>; stable@xxxxxxxxxxxxxxx >> Subject: [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support. >> >> Add support for ECC error decoding on family 17h models 10h-2fh. >> > > Can you please make this more specific? Something like "Add PCI device IDs > for Fam17h Models 10h-2Fh so that amd64_edac_mod will load". > >> Link: https://lkml.kernel.org/r/20180810193623.24629-1- >> mikhail.jin@xxxxxxxxx >> Cc: stable@xxxxxxxxxxxxxxx > > This won't apply to all stable branches. EDAC support for Fam17h was added > in v4.10. > > I'm not sure if the stable tag needs to be modified, or if the stable queues > automatically drop patches that don't apply. > >> Signed-off-by: Michael Jin <mikhail.jin@xxxxxxxxx> >> --- >> drivers/edac/amd64_edac.c | 15 +++++++++++++++ >> drivers/edac/amd64_edac.h | 3 +++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c >> index 18aeabb1d5ee..2d7b6d37d6ec 100644 >> --- a/drivers/edac/amd64_edac.c >> +++ b/drivers/edac/amd64_edac.c >> @@ -3188,6 +3197,12 @@ static struct amd64_family_type >> *per_family_init(struct amd64_pvt *pvt) >> break; >> >> case 0x17: >> + /* Check if CPU model is in range 10h-2fh */ > > This comment is not needed because it's obvious from the code. > > > Other than those few nits this looks good to me. > > Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx> > > Thanks, > Yazen This version of the patch includes tweaks suggested by Yazen in his review for patch v2 (Link: https://lkml.kernel.org/r/BN7PR12MB2593B097267132250140FBEAF83E0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx). Does anyone else have any feedback for this patch I submitted a week ago? Thanks, Michael
