On 13-11-19 09:15 AM, Eric Dumazet wrote: > On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote: >> On 13-11-19 05:04 AM, David Laight wrote: >>>> From: Mark Lord >> .. >>>> except the ax88179_178a driver still does not work in linux-3.12, >>>> whereas it works fine in all earlier kernels. >>>> >>>> That's a regression. >>>> And a simple revert (earlier in this thread) fixes it. >>>> So.. let's revert it for now, until a proper xhci compatible patch is produced. >> ... >>> There is a patch to xhci-ring.c that should fix the SG problem. >>> http://www.spinics.net/lists/linux-usb/msg97176.html >>> >>> I think it should apply to the 3.12 sources. >> >> I am running with that patch here now (thanks), >> and it too appears to prevent the lockups. >> >> But is this patch upstream already? >> If yes, then it needs to get pushed out to -stable for 3.12 at least. >> >> If not upstream, then the revert is probably safest for -stable, >> rather than new code that has never been upstream before. >> > >> Both patches are attached to this email. >> One or the other is required for the USB 3.0 network adapters to function in 3.12. > > I do not see any error in commit f27070158d6754765f2 > ("ax88179_178a: avoid copy of tx tcp packets") > Quite the contrary in fact... > > I suspect a TSO bug, and would rather disable TSO for this nic. David's explanation for the XHCI issue seems to explain it nicely, and the patch he linked to does indeed address/fix the issue, without disabling TSO. So on the evidence, probably NOT a TSO bug. -- Mark Lord Real-Time Remedies Inc. mlord@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html