Re: [PATCH 3.11-stable] virtio: mmio: fix signature checking for BE guests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-11-15 at 10:40 +0000, Jonghwan Choi wrote:
> This patch looks like it should be in the 3.11-stable tree, should we apply
> it?
> 
> ------------------
> 
> From: "Marc Zyngier <marc.zyngier@xxxxxxx>"
> 
> commit 4ae85370720156025e9cb873c13a0afb06ca1612 upstream
> 
> As virtio-mmio config registers are specified to be little-endian,
> using readl() to read the magic value and then memcmp() to check it
> fails on BE (as readl() has an implicit swab).
> 
> Fix it by encoding the magic value as an integer instead of a string.

It certainly doesn't break anything, but doesn't bring anything new into
the equation either (BE guests will still fail for other reasons).

Paweł


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]