On Sun, Aug 12, 2018 at 05:28:10PM +0200, Greg KH wrote:
> On Sun, Aug 12, 2018 at 02:56:49PM +0100, Sudip Mukherjee wrote:
> > Hi Greg,
> >
> > On Sun, Jul 01, 2018 at 11:37:25AM +0200, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > >
> > > The patch below does not apply to the 4.4-stable tree.
> > > If someone wants it applied there, or to any other stable or longterm
> > > tree, then please email the backport, including the original git commit
> > > id to <stable@xxxxxxxxxxxxxxx>.
> >
> > The attached backported patch should apply to 4.4-stable and also to
> > 4.9-stable.
> >
> > Though I am confused about why this should be in stable, unless some
> > later fix, required in stable, depends on this.
>
> That's a good question. Can some IB developer please answer this before
> I queue this up?
It is required for this upstream patch:
commit d8f9cc328c8888369880e2527e9186d745f2bbf6
Author: Jack Morgenstein <jackm@xxxxxxxxxxxxxxxxxx>
Date: Wed May 23 15:30:31 2018 +0300
IB/mlx4: Mark user MR as writable if actual virtual memory is writable
To allow rereg_user_mr to modify the MR from read-only to writable without
using get_user_pages again, we needed to define the initial MR as writable.
However, this was originally done unconditionally, without taking into
account the writability of the underlying virtual memory.
As a result, any attempt to register a read-only MR over read-only
virtual memory failed.
To fix this, do not add the writable flag bit when the user virtual memory
is not writable (e.g. const memory).
However, when the underlying memory is NOT writable (and we therefore
do not define the initial MR as writable), the IB core adds a
"force writable" flag to its user-pages request. If this succeeds,
the reg_user_mr caller gets a writable copy of the original pages.
If the user-space caller then does a rereg_user_mr operation to enable
writability, this will succeed. This should not be allowed, since
the original virtual memory was not writable.
Cc: <stable@xxxxxxxxxxxxxxx>
Fixes: 9376932d0c26 ("IB/mlx4_ib: Add support for user MR re-registration")
Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
Signed-off-by: Jack Morgenstein <jackm@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
