On Wed, 2018-08-08 at 08:41 -0600, Jens Axboe wrote: +AD4- On 7/30/18 3:10 PM, Bart Van Assche wrote: +AD4- +AD4- +-+ACM-ifdef CONFIG+AF8-BLK+AF8-CGROUP +AD4- +AD4- +- +AHs- +AD4- +AD4- +- struct blkcg+AF8-gq +ACo-blkg+ADs- +AD4- +AD4- +- +AD4- +AD4- +- rcu+AF8-read+AF8-lock()+ADs- +AD4- +AD4- +- blkg +AD0- blkg+AF8-lookup(+ACY-blkcg+AF8-root, q)+ADs- +AD4- +AD4- +- rcu+AF8-read+AF8-unlock()+ADs- +AD4- +AD4- +- +AD4- +AD4- +- WARN(blkg, +AD4- +AD4- +- +ACI-request queue +ACU-p is being released but it has not yet been removed from the blkcg controller+AFw-n+ACI-, +AD4- +AD4- +- q)+ADs- +AD4- +AD4- +- +AH0- +AD4- +AD4- +-+ACM-endif +AD4- +AD4- This last hunk should go in the cgroup code. Hello Jens, How about leaving out the +ACM-ifdef CONFIG+AF8-BLK+AF8-CGROUP / +ACM-endif? Would that be sufficient? I just noticed that blkg+AF8-lookup() returns NULL anyway if cgroup support is disabled in the kernel config. Thanks, Bart.
