On Fri, 27 Jul 2018 13:55:03 -0700 Eric Anholt <eric@xxxxxxxxxx> wrote: > Boris Brezillon <boris.brezillon@xxxxxxxxxxx> writes: > > > When there's no scaling requested ->is_unity should be true no matter > > the format. > > > > Also, when no scaling is requested and we have a multi-planar YUV > > format, we should leave ->y_scaling[0] to VC4_SCALING_NONE and only > > set ->x_scaling[0] to VC4_SCALING_PPF. > > > > Doing this fixes an hardly visible artifact (seen when using modetest > > and a rather big overlay plane in YUV420). > > > > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") > > Cc: <stable@xxxxxxxxxxxxxxx> > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx> > > Reviewed-by: Eric Anholt <eric@xxxxxxxxxx> Queued to drm-misc-fixes.