4.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> [ Upstream commit c259b4fb33ee6e7667bf1d34bf0803b7c5fdbdce ] Devlink resources registered with devlink_resource_register() have to be unregistered. Fixes: 37923ed6b8ce ("netdevsim: Add simple FIB resource controller via devlink") Signed-off-by: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> Reviewed-by: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/net/netdevsim/devlink.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/netdevsim/devlink.c +++ b/drivers/net/netdevsim/devlink.c @@ -206,6 +206,7 @@ void nsim_devlink_teardown(struct netdev struct net *net = nsim_to_net(ns); bool *reg_devlink = net_generic(net, nsim_devlink_id); + devlink_resources_unregister(ns->devlink, NULL); devlink_unregister(ns->devlink); devlink_free(ns->devlink); ns->devlink = NULL;