Re: [PATCH] X86 microcode AMD: Missing firmware file is not an error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 12, 2013 at 10:26:42PM +0100, Ingo Molnar wrote:
> Yes, but it's cheaper to pick it one time for the mainline kernel and let 
> all the dozens of Linux distros have it.
> 
> The 'let the distro pick the patch' applies for cases where we _disagree_ 
> with the urgency of the patch, where the patch carries real risks, and 
> where the distro consciously takes that risk because it thinks it has 
> different priorities.
> 
> I don't think there's much of a disagreement in this particular case: it's 
> a bug, it annoys users, it annoys distros.
> 
> The only 'weirdness' about it is that it's "too trivial" - but trivial 
> annoyances can have a relatively high downstream cost as well, if they are 
> prominent and scary enough ...
> 
> > Adding the stable tag with a 
> > huuge-exception-BUT-BUT-this-time-we-need-it-explanation just so to fit 
> > some automation stuff is an overkill, if you ask me.
> 
> I don't think it's a huge exception - just a somewhat unusual case.
> 
> Agreed?

Sure, I'm just saying that the above justification should be somewhere
explaining why the stable tag so that people know.

Or, we probably even want to amend stable rules with such a rule for
"channeling" patches to distros through stable... ? Something like below
maybe:

diff --git a/Documentation/stable_kernel_rules.txt b/Documentation/stable_kernel_rules.txt
index b0714d8f678a..aa9f553e654a 100644
--- a/Documentation/stable_kernel_rules.txt
+++ b/Documentation/stable_kernel_rules.txt
@@ -8,6 +8,9 @@ Rules on what kind of patches are accepted, and which ones are not, into the
  - It must fix only one thing.
  - It must fix a real bug that bothers people (not a, "This could be a
    problem..." type thing).
+ - An exception to the above rule would be an annoyance/correctness
+   fixlet which would be good-to-have in all distros so "channeling" it
+   through -stable is OK.
  - It must fix a problem that causes a build error (but not for things
    marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
    security issue, or some "oh, that's not good" issue.  In short, something

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]