On Fri, Jul 27, 2018 at 9:36 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Jul 26, 2018 at 08:46:22PM +0300, Or Gerlitz wrote: >> On Thu, Jul 26, 2018 at 8:45 PM, Or Gerlitz <ogerlitz@xxxxxxxxxxxx> wrote: >> > [ Upstream commit f8f4bef322e4600c5856911c7a632c0e3da920d6 ] >> > >> > When dealing with ingress rule on a netdev, if we did fine through the >> > conventional path, there's no need to continue into the egdev route, >> > and we can stop right there. >> > >> > Not doing so may cause a 2nd rule to be added by the cls api layer >> > with the ingress being the egdev. >> > >> > For example, under sriov switchdev scheme, a user rule of VFR A --> VFR B >> > will end up with two HW rules (1) VF A --> VF B and (2) uplink --> VF B >> > >> > Fixes: 208c0f4b5237 ('net: sched: use tc_setup_cb_call to call per-block callbacks') >> > Signed-off-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx> >> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> >> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> > --- >> > >> > Hi Greg, >> > >> > The commit that introduced the problem dates to 4.15 and the fix made >> > on 4.17. I see the fix was pushed to 4.16-stable but not to 4.15-stable, >> > so sending it now. >> >> Sorry for not marking it on the subject line, but this is for 4.15-stable > > 4.15 is long end-of-life, sorry, there's nothing I can do for that > kernel anymore. Please always look at the front page of kernel.org for > what kernels are still "alive" when doing backports so you don't end up > doing work for no reason. I see, so I missed the train... luckily I can tell people that step on the bug to catch the next train/s - long live linux :) Or.