On Thu, Jul 26, 2018 at 08:12:02AM +1000, Stefano Brivio wrote:
> On Wed, 25 Jul 2018 18:06:25 +0200
> Philip Müller <philm@xxxxxxxxxxx> wrote:
>
> > Hi Greg, hi Stefano,
> >
> > seems adding "cifs: Fix slab-out-of-bounds in send_set_info() on SMB2
> > ACE setting" (commit 748144f) [1] created a regression within linux
> > v4.14 kernel series. Writing to a mounted cifs either freezes on writing
> > or crashes the PC. A more detailed explanation you may find in our
> > forums [2]. Reverting the patch, seems to "fix" it. Thoughts?
>
> Hi Philip,
>
> thanks for reporting this.
>
> My bad, I didn't check how the backport of f46ecbd97f50 ("cifs: Fix
> slab-out-of-bounds in send_set_info() on SMB2 ACE setting") looked like on
> 4.14. As 4.14 doesn't have commit 2fc803efe614 ("cifs: remove rfc1002
> header from smb2_set_info_req"), the effect is substantially different.
>
> Greg, I would need some time to check if we actually need this at all on
> 4.14, to do a proper backport in case and to run tests. Could you please
> revert this on 4.14.y for the moment being? If a backport is needed, I'll
> send it later on. Thanks!
Now reverted, thanks.
greg k-h
